Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update FOREIGN_DAILY_LIMIT & FOREIGN_MAX_AMOUNT_PER_TX for bridge modes #172

Merged
merged 2 commits into from
Apr 16, 2019
Merged

update FOREIGN_DAILY_LIMIT & FOREIGN_MAX_AMOUNT_PER_TX for bridge modes #172

merged 2 commits into from
Apr 16, 2019

Conversation

andogro
Copy link
Contributor

@andogro andogro commented Apr 15, 2019

  • Changed configuration options for FOREIGN_DAILY_LIMIT and FOREIGN_MAX_AMOUNT_PER_TX, and commented out FOREIGN_MIN_AMOUNT_PER_TX, for erc20-to-erc20 and erc20-to-native bridge modes.
  • Modified several comments for line length

@ghost ghost assigned andogro Apr 15, 2019
akolotov
akolotov requested changes Apr 15, 2019
View reviewed changes
Copy link
Collaborator

@akolotov akolotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to specify every where (for the configurations related to both Home and Foreign) that ..._MAX_AMOUNT_PER_TX must be less than ..._DAILY_LIMIT?

deploy/README.md Show resolved Hide resolved
deploy/README.md Show resolved Hide resolved
@ghost ghost removed the in progress label Apr 15, 2019
@akolotov akolotov changed the base branch from master to develop April 16, 2019 06:42
@akolotov akolotov merged commit 8ed024e into omni:develop Apr 16, 2019
@ghost ghost removed the review label Apr 16, 2019
@akolotov akolotov mentioned this pull request May 22, 2019
Merged
@PinkDiamond1 PinkDiamond1 mentioned this pull request Feb 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akolotov akolotov akolotov approved these changes

Assignees

@andogro andogro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andogro @akolotov